solidusio-contrib / solidus_active_shipping

:package: Solidus integration for Shopify's active_shipping gem.
8 stars 22 forks source link

rubygems releases? #44

Open brchristian opened 7 years ago

brchristian commented 7 years ago

It looks like there has been a considerable amount of activity in the master branch of this repo, but there has only been one rubygems release. Can we get a new release cut that incorporates these changes?

Also, I don’t see branches for v2.1, v2.2, etc., as are present in most of the other Solidus gems and extensions. That might be another helpful thing for compatibility. As it stands, I’m running Solidus 2.1 in production and am not really sure what to be using -- whether the 1.0.0 gem, the master branch here, the last commit before 2.2 support was added, etc.

Cheers!

forkata commented 7 years ago

We can definitely cut a new release to include the changes we've added since the initial v1.0.0 publish of this extension to Rubygems. The changes since that release remove the dependence on solidus_frontend and add calculators for the new Canada Post API.

With regards to your second question, we have tried to move away from having version specific branches for Solidus extensions in favor of maintaining compatibility with all versions of Solidus wherever possible. The current release on Rubygems is compatible with all versions of Solidus, so you can feel free to use that with Solidus 2.1 until we publish a new release.

forkata commented 7 years ago

Another thing that you may find useful is the compatibility matrix for solidus-contrib extensions which you can find here http://extensions.solidus.io/. It is generated by running the tests on the master branch against different supported versions of Solidus.

brchristian commented 7 years ago

@forkata Sounds good on all fronts, thank you! 👍

brchristian commented 6 years ago

@forkata I’m updating my app to Solidus 2.3 and for some reason the rubygems version doesn’t appear to have compatible dependencies with the rest of the Solidus 2.3 gems, and bundle update won’t complete successfully. When I use the master branch here, it works fine.

Perhaps we can have a rubygems release so that folks upgrading to Solidus 2.3 don’t need to point to github and can continue using the gem versions? What do you think?