Updating the SolidusAftepay::PaymentMethod sets the minimum_amount and maximum_amount preferences to 0.0

solidusio-contrib / solidus_afterpay

Apache License 2.0

1 stars 1 forks source link

Updating the SolidusAftepay::PaymentMethod sets the minimum_amount and maximum_amount preferences to 0.0 #18

Closed ChristianRimondi closed 3 years ago

ChristianRimondi commented 3 years ago

Updating the SolidusAftepay::PaymentMethod sets the minimum_amount and maximum_amount preferences to 0.0 instead of leaving them nil. This is causing an issue here because instead of retrieving the configuration from Afterpay, the method always returns a 0.0..0.0 range.

vassalloandrea commented 3 years ago

This should be the correct behavior:

if the minimum and maximum are set inside the admin, use these values to show or not the payment methods
if the minimum and maximum are not set inside the admin, do not set it to 0 but fetch this information from Afterpay

An additional goal is: fetch the information from Afterpay and cache them for 1 day.