search

solidusio-contrib / solidus_content

BSD 3-Clause "New" or "Revised" License
8 stars 9 forks source link

Fix Entry creation in README #21

Closed peterberkenbosch closed 4 years ago

peterberkenbosch commented 4 years ago

To create an Entry we have call create on the Entry and content_type does not exist anymore, updated this to the proper entry_type attribute.

The rest of the README is a bit behind as well, the data_for method is not present. I would love to update the README with the proper interface, but not sure what that currently is.

To render data we have to get an Entry instance and call data or content on that instance.

The data_for method looks nice though, pass in the type and slug and get data. What is the bigger picture here? Should we mark this as WIP in the README?

I'm implementing this currently and I have so many questions :) (and opinions ;) ).

peterberkenbosch commented 4 years ago

@elia I'm more then happy to jump in and push this forward. Let me know if you want to jump on a call / slack discussion etc

elia commented 4 years ago

Thanks @peterberkenbosch! (I'll invite you to the dedicated slack channel)