search

solidusio-contrib / solidus_content

BSD 3-Clause "New" or "Revised" License
8 stars 9 forks source link

Add integration with DatoCMS #42

Closed delphaber closed 4 years ago

delphaber commented 4 years ago

Hi :)

This PR adds integration with DatoCMS

delphaber commented 4 years ago

Don't know why tests did not run 🤔

elia commented 4 years ago

@delphaber once I get https://github.com/solidusio-contrib/solidus_content/pull/43 reviewed and merged they'll be fine, sorry for the inconvenience

elia commented 4 years ago

@delphaber done, a rebase should fix it up

elia commented 4 years ago

@delphaber looks like it didn't start… I just tried to disable and re-enable building from forks in CircleCI, can you try again please?

image
delphaber commented 4 years ago

Pushed again :) let's see!

delphaber commented 4 years ago

It didn't work :(

elia commented 4 years ago

@delphaber I've found this note in the CircleCI doc:

Note: If a user submits a pull request to your repository from a fork, but no pipeline is triggered, then the user most likely is following a project fork on their personal account rather than the project itself of CircleCi, causing the jobs to trigger under the user’s personal account and not the organization account. To resolve this issue, have the user unfollow their fork of the project on CircleCI and instead follow the source project. This will trigger their jobs to run under the organization when they submit pull requests.

https://circleci.com/docs/2.0/oss/ is that the case?

delphaber commented 4 years ago

@elia I created a fresh account on CircleCI and now tests are running 🤔

I didn't know I had to do that for PRs coming from forks! Sorry about that!

elia commented 4 years ago

All good, at least we've found the solution đź‘Ť

delphaber commented 4 years ago

@elia I rebased my PR on master. All checks have passed now :)