search

solidusio-contrib / solidus_importer

Solidus importer extension to migrate data from other eCommerce systems
BSD 3-Clause "New" or "Revised" License
15 stars 30 forks source link

Update _form.html.erb #56

Closed iqre8 closed 1 year ago

iqre8 commented 3 years ago

Prevent people from uploading excel files. Who is people? We are people....

jarednorman commented 3 years ago

Bad news: Windows machines with Excel installed will sometimes send CSVs with a propriety MIME that will ruin your day, application/vnd.ms-excel. You might be thinking, "wait, that doesn't even say it's a CSV," and sadly, you're right. It doesn't. We've seen this issue with other CSV handling systems. 😒

I'd love to find a good solution for both this issue as well as #55 so that we can be better friends with people using Excel and live in harmony.

kennyadsl commented 3 years ago

@iqre8 what about doing this on the server-side instead?

iqre8 commented 3 years ago

@kennyadsl I would prefer it be done on both sides. Client side would reduce the amount of 'errors' caused. And server-side would primarily be needed to stop malicious attempts. It certainly won't make the app noticable slower on the client side.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It might be closed if no further activity occurs. Thank you for your contributions.