solidusio-contrib / solidus_importer

Solidus importer extension to migrate data from other eCommerce systems
BSD 3-Clause "New" or "Revised" License
15 stars 30 forks source link

Option Type not created when an Option Name1 is specified (likely will cause an issue with Option Name2 etc as well) #66

Closed iqre8 closed 3 years ago

iqre8 commented 3 years ago

Doesn't create an option type when 'Option1 Name' is specified. This causes the user to be unable to navigate to the product -> images, variants, prices, properties.

NoMethodError in Spree::Admin::ImagesController#index 
NoMethodError in Spree::Admin::Variants#index 
NoMethodError in Spree::Admin::Prices#index 

Showing /usr/share/rvm/gems/ruby-2.7.2/gems/solidus_backend-2.11.5/app/views/spree/admin/variants/_table.html.erb where line #29 raised: 
Showing /usr/share/rvm/gems/ruby-2.7.2/gems/solidus_backend-2.11.5/app/views/spree/admin/prices/index.html.erb where line #23 raised: 
undefined method `position' for nil:NilClass
    def options_text
      values = option_values.includes(:option_type).sort_by do |option_value|
        option_value.option_type.position
      end

solidus_core (2.11.5) app/models/spree/variant.rb:197:in `block in options_text' 
NoMethodError in Spree::Admin::ProductProperties#index 
Showing /usr/share/rvm/gems/ruby-2.7.2/gems/solidus_backend-2.11.5/app/views/spree/admin/product_properties/index.html.erb where line #53 raised: 
undefined method `presentation' for nil:NilClass
      <% @option_types.each do |option_type, option_values| %>
        <div class="field">
          <%= label :option_type_presentation, option_type.presentation %>
          <%= select_tag "ovi[]", options_from_collection_for_select(option_values, :id, :presentation, params[:ovi]), class: 'custom-select fullwidth', include_blank: true, id: "#{option_type.name}_option_type_select" %>
        </div>
      <% end %>