search

solidusio-contrib / solidus_importer

Solidus importer extension to migrate data from other eCommerce systems
BSD 3-Clause "New" or "Revised" License
15 stars 30 forks source link

Avoid touching all products associated with existing option type imported #70

Open kennyadsl opened 3 years ago

kennyadsl commented 3 years ago

Currently, when importing a product that has a specific option type, all existing products associated with that option type are touched.

This is happening because we are doing these operations at each product import:

https://github.com/solidusio-contrib/solidus_importer/blob/c89d279d81bd6c06a5b294163dc1a3824f7fd1aa/lib/solidus_importer/processors/option_types.rb#L18-L23

I think we should try to change the option type only if needed. It is not even clear why we need to update its position, since that position is a global value against other option types and not something specific for the product imported.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It might be closed if no further activity occurs. Thank you for your contributions.