search

solidusio-contrib / solidus_importer

Solidus importer extension to migrate data from other eCommerce systems
BSD 3-Clause "New" or "Revised" License
15 stars 30 forks source link

Check for duplicated option values and avoid adding them #76

Closed vdanciu closed 3 years ago

vdanciu commented 3 years ago

When the import file has more lines for each variant in order to specify more images per variant the mapping to the variant is made through options instead of variant sku (which is optional). As a result of repeating the options on all lines they are also added by the importer multiple times ending. This change avoids adding them if already present.

vdanciu commented 3 years ago

You don't need to open a new PR; you can amend/rebase the existing commits and force push your branch so we can keep the conversation about the change all together.

My git skills are abysmal. I was working on something else in the meantime and my master branch moved forward with new changes so I created a branch only for this and did not know how to amend a PR from having vdanciu/master as source to having vdanciu/duplicated-options as source and since I was short on time I just closed it.

Thank you for your patience. I removed the extra changes I forgot in the PR (for debugging).