search

solidusio-contrib / solidus_importer

Solidus importer extension to migrate data from other eCommerce systems
BSD 3-Clause "New" or "Revised" License
15 stars 30 forks source link

Fix broken specs #90

Closed johnpitchko closed 1 year ago

johnpitchko commented 1 year ago

Specs were failing so I took a stab at fixing them. Seem to be related to Spree::Address. I could be wrong on some of these as I was not the original author so please let me know if I misinterpreted the intention of these specs. But hey, at least all the specs run now!

The issue with import_spec.rb was that the CSV file being imported contained two customers that lived in two separate provinces, however the spec was only creating a single province. Creating both provinces resolved that issue.

The issue with customer_address_spec.rb was more tricky. I'm no expert, but it seems that the factory cannot create a state in the incorrect country. So I created a valid state, then updated it to associate it with the wrong country.

The second issue with that spec seemed to be written for when the country does not have the state specified in the imported record.

jarednorman commented 1 year ago

Looks good, will approve if the feedback gets squashed into the original commit.

johnpitchko commented 1 year ago

Thanks @jarednorman. I squashed to a single commit now.

johnpitchko commented 1 year ago

Couple of issues here. Not sure why the rspec job is failing; appears to be a network error connecting to rubygems.org.

Also unsure why the specs are failing. Seem to run fine on my workstation. Unfortunately I cannot re-run them on CircleCI. Does someone else have authorization?

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It might be closed if no further activity occurs. Thank you for your contributions.