solidusio-contrib / solidus_reviews

Product review/rating functionality for your Solidus store.
BSD 3-Clause "New" or "Revised" License
19 stars 48 forks source link

Fix specs to allow support for solidus 3 #102

Closed seriousammy closed 3 years ago

seriousammy commented 3 years ago

There are two changes, the first is to update a fixture asset to be local. The thinking-cat image was being grabbed from the the solidus gem. In v2.11 the thinking-cat image is no longer available. I imported that image to be available in spec/fixtures and updated the appropriate paths in the spec.

The second change is a minor one that gets rid of a warning that may cause false positives.

EDIT: I had to add some additional exceptions into the existing rubocop_todo.yml file. This is beyond the scope of this PR, and should be addressed at a later time. This will allow the CI build to pass (failure in lint-code).

Closes #101