search

solidusio-contrib / solidus_searchkick

Searchkick for Solidus
MIT License
5 stars 6 forks source link

Reference to `currently_valid_prices` breaks this extension in Solidus >= 3.1 #21

Closed michaelmichael closed 1 year ago

michaelmichael commented 2 years ago

As of Solidus 3.1.0, currently_valid_prices has been moved into a method. Since this extension references it as an association, the extension is broken on Solidus >= 3.1.0

I believe we can simply change this line to 

      includes_clause =  { master: [:prices] }

And that fixes it—in our specs anyway. I will submit a pull request with that change.

kennyadsl commented 2 years ago

Hey @michaelmichael, thanks for the help here. Let me know when the PR is ready for review!

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.