solidusio-contrib / solidus_searchkick

Searchkick for Solidus
MIT License
5 stars 6 forks source link

Remove call to deprecated `currently_valid_prices` association #23

Closed michaelmichael closed 2 years ago

michaelmichael commented 2 years ago

As noted in #21, the call to currently_valid_prices breaks this gem when used with Solidus >= 3.1. Since currently_valid_prices has been moved into a method, we should only include [:prices] in the includes clause.

michaelmichael commented 2 years ago

We can't pass specs without also adding elasticseasrch or opensearch as a dependency. I will close this PR and open a new one that addresses this.