search

solidusio-contrib / solidus_social

Building block for social authentication in your Solidus store.
BSD 3-Clause "New" or "Revised" License
27 stars 52 forks source link

Remove omniauth-facebook #104

Open DanielePalombo opened 2 years ago

DanielePalombo commented 2 years ago

omniauth-facebook extension downgrades omniauth lesser than V2. Rather than lock omniauth version, we think it would be better to remove omniauth-facebook gem and the commit that lock the omniauth version so that the user can add it back manually if required.

ref https://github.com/solidusio-contrib/solidus_social/pull/102#issuecomment-1213046997 https://github.com/solidusio-contrib/solidus_social/commit/9bc5e0531abf1a2750624e4f07eaee7864d3fcf8

piyushswain commented 2 years ago

On further investigation, the problem now seems to be with the omniauth gem instead of the omniauth-facebook gem. Some breaking changes were introduced in omniauth for v2.0 (changelog) which have resulted in failing sign_in_specs.

This issue appears only in omniauth versions >= 2.0. Solidus Social is still working fine for omniauth version 1.9.1.

piyushswain commented 2 years ago

Screenshot 2022-08-17 at 3 50 48 PM This is the error when clicking on a social login option on the login page