search

solidusio-contrib / solidus_static_content

:page_facing_up: Content management for your Solidus store.
BSD 3-Clause "New" or "Revised" License
21 stars 40 forks source link

Prepare Solidus Static Content for Solidus 3.0 #75

Closed kennyadsl closed 3 years ago

kennyadsl commented 3 years ago

Update this extension so that it works with Solidus 3.0 by making sure the specs pass.

jarednorman commented 3 years ago

I got this one.

jarednorman commented 3 years ago

I opened #76 to address an issue running the specs against recent versions of Chrome when headless, but this extension doesn't trigger any deprecations on v2.11.

seand7565 commented 3 years ago

@jarednorman The PR above has been merged, is this issue closable now?

jarednorman commented 3 years ago

It is, so long as we're closing these issues without yet having updated the Solidus dependency in the gemspec. I wasn't sure what the plan was there.

kennyadsl commented 3 years ago

Yes, I think we should also update the dependency in the gemspec when needed.