solidusio / circleci-orbs-extensions

A CircleCI Orb that runs specs for extensions against currently supported Solidus versions
https://circleci.com/orbs/registry/orb/solidusio/extensions
3 stars 8 forks source link

Match the Rails name for sqlite in `$DB` #65

Closed elia closed 1 year ago

elia commented 1 year ago

Summary

We traditionally used sqlite and had code to convert it to sqlite3 when using it as a rails new --database=… option. Moving to use the same naming simplifies the setup. Sandbox and solidus_core script should already be compatible with the rails-compatible name.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed (~cross them out~ if they are not):

elia commented 1 year ago

Reopening from a branch in the same repo so the publishing CI step will work, see #66.