search

solidusio / rubocop-solidus

Automatic Solidus code style checking tool.
MIT License
4 stars 4 forks source link

Replace icon with solidus_icon #32

Open DanielePalombo opened 1 year ago

DanielePalombo commented 1 year ago

In solidus 2.3 iconhelper has been deprecated to solidus_icon

Ref https://github.com/solidusio/solidus/commit/62a37ccd358e416d8d6a4a5165a31593e184ac34

PR: https://github.com/nebulab/rubocop-solidus/pull/17

solidus minimum version: 2.3

DanielePalombo commented 1 year ago

icon is too much generic to deprecate. We agree that we can remove it for now and re-evaluate if it is worth it to reintroduce it, when we'll have a real project to migrate.

DanielePalombo commented 1 year ago

Moved to ready to be removed. Then we can move it to backlog

DanielePalombo commented 1 year ago

This COP could be related to #37