Restore solidus/tax_category_deprecated warning cop - Githubissues

solidusio / rubocop-solidus

Automatic Solidus code style checking tool.

MIT License

4 stars 4 forks source link

Restore solidus/tax_category_deprecated warning cop #63

Closed safafa closed 11 months ago

safafa commented 12 months ago

Description

This PR restores solidus/tax_category cop issue 53

Severity:

[ ] - info
[ ] - refactor
[ ] - convention (default)
[x] - warning
[ ] - error
[ ] - fatal

Wrong Code

  model.tax_category = data

Correct Code

  model.tax_categories = [data]

Solidus PR Link: # Replace with link to Solidus PR where the change has been made.

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one cop with a clear title and description.
[x] Feature branch is up-to-date with main (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Ran and ensured all tests are passing on a development environment.
[x] If this is a new cop, added an entry for the cop on /config/default.yml
[x] Updated Changelog

safafa commented 12 months ago

Thank you @MassimilianoLattanzio I made all the requested changes here