Add new Solidus/SpreeDefaultAddressDeprecated cop

the-krg commented 10 months ago

Description

Add a new cop that checks if user.default_address or user.default_user_address are being used, and warns user to change to user.ship_address or user.default_user_ship_address instead.

Severity:

[ ] - info
[ ] - refactor
[X] - convention (default)
[ ] - warning
[ ] - error
[ ] - fatal

Wrong Code

      user.default_address
      user.default_user_address

Correct Code

      user.ship_address
      user.default_user_ship_address

Solidus PR Link: https://github.com/solidusio/solidus/pull/3563

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one cop with a clear title and description.
[x] Feature branch is up-to-date with main (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Ran and ensured all tests are passing on a development environment.
[x] If this is a new cop, added an entry for the cop on /config/default.yml
[x] Updated Changelog

the-krg commented 6 months ago

Sorry, I'm late on this. Update with the latest suggestions, so we can merge or close it! If we don't want a 0.3.0 release, just let me know and I'll keep it as <<next>>.

MassimilianoLattanzio commented 6 months ago

Sorry, I'm late on this. Update with the latest suggestions, so we can merge or close it! If we don't want a 0.3.0 release, just let me know and I'll keep it as <<next>>.

Hey Enzo, thanks for the update. ATM, we paused working on this. As soon as we will restart working on it, I'll review it.

solidusio / rubocop-solidus

Add new Solidus/SpreeDefaultAddressDeprecated cop #64