solidusio / solidus

🛒 Solidus, the open-source eCommerce framework for industry trailblazers.
https://solidus.io
Other
4.97k stars 1.28k forks source link

Tracking Bootstrap layout implementation #1153

Closed Mandily closed 4 years ago

Mandily commented 8 years ago

While we're in the process of converting Solidus core pages to the new bootstrap layouts, I'd like to keep track of what's been done and what's still outstanding. When a page is complete, we'll mark it with a strikethrough.

Orders

mtylty commented 8 years ago

is this going to be completed with one PR per page?

cbrunsdon commented 8 years ago

@mtylty I think its more of a "one PR per what makes sense". Would be nice if it was a small enough unit of work that was quick to review, but in some cases it might make sense to cut through multiple things at once.

Murph33 commented 8 years ago

With regards to that I've done some preliminary work using the layouts @graygilmore is introducing in #1114 on the index views without any forms and it's just been adding one line of <% admin_layout 'full-width' %> and removing references to the old skeleton system.

harmonymjb commented 7 years ago

I've spent some time working with @Mandily on the product related pages. I'm still working through a few small improvements and then I'll submit a PR for the product edit page and solicit comments.

JDutil commented 4 years ago

I believe the admin UI has been updated so this issue could be closed as it's out of date. /cc @jacobherrington @spaghetticode @gmacdougall

tvdeyen commented 4 years ago

Yes. Thanks for reminding.