Closed mamhoff closed 6 months ago
You need to run
bin/dev
but even with this the solidus_admin/tailwind.css
does not get build in the admin/app/assets/builds
folder.
@elia what are the steps to set up a working sandbox locally with solidus_admin
. And how do the compiled assets end up in the engine folder in the released gem? Do we have a build step somewhere?
I can confirm that solidus_admin/tailwind.css
is in the built gem, but it is missing in the git checkout. What makes sense, but still I cannot see a task that builds the file during release.
Workaround:
admin
bundle exec rake tailwindcss:build
bin/dev
@elia ideally we would have a top level rake task for this or check in the tailwind.css file into the repo, because it wont change often. Then rebuild it via GH actions on push or something (as we do in Alchemy to build our admin bundles)
you can reduce the number of commands to:
bin/rake -C admin tailwindcss:build
bin/dev
We could also touch
or build the css file as part of the sandbox script, just to avoid that nasty error, but bin/dev
would still be the preferred way.
All of that should be better documented once we finalize #5595, sorry about the inconvenience.
I think this should be automated, and part of the solidus installer (at least). Also, I think this affects all extensions in the ecosystem, as none that I looked at over the past couple of days (and I looked at a few) currently build. Even the ones that should build fail with errors related to SolidusAdmin
.
@mamhoff @elia now that #5600 has been merged most extensions should build again, right?
@elia what do you think about committing the built tailwind css file into the admin repo (and update it on PR merge)? That file won't change much (at least once the admin has been built out). And even in until then it makes to have it updated regularly (not just on gem release). Thoughts?
In both Solidus 4.3 and in the main branch, the sandbox generates, but cannot be used. I fails with the following error:
Solidus Version:
branches
v4.3
andmain
To Reproduce
Current behavior
Above failure
Expected behavior
I expect the sandbox to work.
Desktop (please complete the following information):
Additional context
I would have loved to provide a fix for a flaky spec with the new admin, but I can't.