search

solidusio / solidus

🛒 Solidus, the open-source eCommerce framework for industry trailblazers.
https://solidus.io
Other
5.04k stars 1.29k forks source link

[admin] Consider committing the built tailwind css file into the admin repo #5655

Open elia opened 9 months ago

elia commented 9 months ago 
          What do you think about committing the built tailwind css file into the admin repo (and update it on PR merge)? That file won't change much (at least once the admin has been built out). And even until then it makes sense to have it updated regularly (not just on gem release).

People might use solidus_admin from git source like this

# Gemfile
gem "solidus_admin", github: "solidusio/solidus", branch: "v4.3"

(in order to get bug fixes early for stable versions that have not been released yet.)

We want to make sure they get the admin css file, right?

_Originally posted by @tvdeyen in https://github.com/solidusio/solidus/pull/5595#discussion_r1456396184_

tvdeyen commented 1 month ago

With the recent issues on CircleCI regarding the tailwind rake task we install in all host apps (!!) I think we really should do that. We are doing this for a very long time in Alchemy and we have zero issues or complaints.