solidusio / solidus

πŸ›’ Solidus, the open-source eCommerce framework for industry trailblazers.
https://solidus.io
Other
4.99k stars 1.29k forks source link

[Admin] Introduce RMA reasons creation & modification capability #5829

Closed MadelineCollier closed 1 month ago

MadelineCollier commented 1 month ago

Summary

This PR finishes off the excellent work that @forkata and @kjriga started in https://github.com/solidusio/solidus/pull/5809 and adds request specs to placate Codecov. It also takes care of the modification/edit/update flow. This is for issue https://github.com/solidusio/solidus/issues/5808 [Admin][Settings][Refunds and Returns] Introduce RMA reason creation and modification capability.

The attached video shows the functionality visually:

https://github.com/user-attachments/assets/aefbe9dc-b104-49d3-bd57-9687e3e4cc11

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.08%. Comparing base (2ae2bfd) to head (10eb257). Report is 11 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #5829 +/- ## ========================================== + Coverage 89.03% 89.08% +0.04% ========================================== Files 737 739 +2 Lines 17188 17245 +57 ========================================== + Hits 15304 15362 +58 + Misses 1884 1883 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

forkata commented 1 month ago

Thanks for taking this to the 🏁 @MadelineCollier, great work here πŸŽ‰