[Admin] Allow assignment of permission sets when creating/editing admin roles

MadelineCollier commented 1 month ago

Note for Reviewers

This PR is part of this issue: https://github.com/solidusio/solidus/issues/5823

I went with checkboxes instead of the view/edit dropdowns as they were becoming complicated to un-pack on the backend with each select having its own form input and array of permission_set_ids.

I also added a component for the CheckboxRow as that whole chunk of code repeated itself 14 times, and any other methods of handling that repetition (partial, helper) proved awful to work with and messy to implement & maintain.

The attached video shows the functionality visually.

https://github.com/user-attachments/assets/07bf8b47-468d-4e0f-ac40-c5b6df23bd51

Screenshots:

Component preview

"All" scope

"Admin" scope

Summary

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

[x] I have written a thorough PR description.
[x] I have kept my commits small and atomic.
[x] I have used clear, explanatory commit messages.

The following are not always needed:

📖 I have updated the README to account for my changes.
📑 I have documented new code with YARD.
🛣️ I have opened a PR to update the guides.
✅ I have added automated tests to cover my changes.
📸 I have attached screenshots to demo visual changes.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 98.34711% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.24%. Comparing base (d81043a) to head (3239325). Report is 7 commits behind head on main.

Files with missing lines	Patch %	Lines
...lib/spree/permission_sets/configuration_display.rb	60.00%	2 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #5846 +/- ## ========================================== + Coverage 89.17% 89.24% +0.06% ========================================== Files 749 753 +4 Lines 17395 17515 +120 ========================================== + Hits 15512 15631 +119 - Misses 1883 1884 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

MadelineCollier commented 3 weeks ago

I'll just fix these failing specs and then it should be good to re-review :)

MadelineCollier commented 3 weeks ago

Updated the screenshots and recordings, thanks for all the time put into many rounds of reviews everyone :) Much appreciated!

solidusio / solidus