solidusio / solidus

🛒 Solidus, the open-source eCommerce framework for industry trailblazers.
https://solidus.io
Other
5.04k stars 1.3k forks source link

Remove rails binstubs from built gems #5917

Closed tvdeyen closed 1 week ago

tvdeyen commented 1 week ago

The bin/rails script is solely used for local dev purposes. Since the default bindir from Rubygems is bin the binstub gets installed with the gems. This can cause issues with the rails command coming from rails itself.

Also removing the old script/rails files, which were excluded to solve the same issue.

tvdeyen commented 1 week ago

Excerpt from current solidus_legacy_promotions gem metadata file

--- !ruby/object:Gem::Specification
name: solidus_legacy_promotions
[...]
bindir: bin
[...]
files:
[..]
- bin/rails
[...]

which reveals that bindir is bin and bin/rails is included

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.54%. Comparing base (b1a3796) to head (dde8966). Report is 4 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #5917 +/- ## ======================================= Coverage 89.54% 89.54% ======================================= Files 783 783 Lines 17994 17994 ======================================= Hits 16113 16113 Misses 1881 1881 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 1 week ago

💚 All backports created successfully

Status Branch Result
✅ v4.4

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details