solidusio / solidus

🛒 Solidus, the open-source eCommerce framework for industry trailblazers.
https://solidus.io
Other
5.04k stars 1.3k forks source link

[Admin] Add product properties admin UI #5926

Open forkata opened 1 week ago

forkata commented 1 week ago

Summary

This change addresses #5857 and introduces a new UI for creating and editing product properties in the new admin.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 83.78378% with 6 lines in your changes missing coverage. Please review.

Project coverage is 89.52%. Comparing base (e6e0243) to head (7a8bbd6).

Files with missing lines Patch % Lines
...controllers/solidus_admin/properties_controller.rb 77.77% 6 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #5926 +/- ## ========================================== - Coverage 89.53% 89.52% -0.02% ========================================== Files 782 783 +1 Lines 17980 18015 +35 ========================================== + Hits 16099 16128 +29 - Misses 1881 1887 +6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tvdeyen commented 1 week ago

Probably a rebuild of #5892

forkata commented 5 days ago

Probably a rebuild of #5892

Oh no! I didn't realize that was happening already 😞 We have this as an issue and on the Project board, but I guess not many people are aware of that.

jarednorman commented 5 days ago

How do we want to proceed here? The other PR needs a little love, but I'm not sure how much the two differ.