solidusio / solidus

🛒 Solidus, the open-source eCommerce framework for industry trailblazers.
https://solidus.io
Other
5.04k stars 1.29k forks source link

Only set promo configuration to legacy if no other set #5928

Closed mamhoff closed 6 days ago

mamhoff commented 1 week ago

This sets the promotion configuration to the legacy promotion system if no other promotion system, like solidus_promotion has been configured in the spree initializer.

This should get rid of errors people encounter when trying to use solidus_promotions, but the system being reconfigured without their intervention to use the legacy system.

Here's the problem this should solve:

grafik

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.54%. Comparing base (8ff6267) to head (f4d24f2). Report is 8 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #5928 +/- ## ========================================== + Coverage 87.81% 89.54% +1.72% ========================================== Files 476 782 +306 Lines 11656 17988 +6332 ========================================== + Hits 10236 16107 +5871 - Misses 1420 1881 +461 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.