solidusio / solidus

🛒 Solidus, the open-source eCommerce framework for industry trailblazers.
https://solidus.io
Other
5.04k stars 1.3k forks source link

Display the store's currency in the Admin Order Index Component #5929

Open magpieuk opened 1 week ago

magpieuk commented 1 week ago

Admin order index page doesn't reflect the stores currency.

Summary

Changed admin orders index page to use display_total rather than number_to_currency(order.total) this displays the correct currency for the order rather than defaulting to USD

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.53%. Comparing base (e6e0243) to head (06c2755). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #5929 +/- ## ======================================= Coverage 89.53% 89.53% ======================================= Files 782 782 Lines 17980 17980 ======================================= Hits 16099 16099 Misses 1881 1881 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kennyadsl commented 1 week ago

@magpieuk thanks for the contribution. Can you please post a screenshot of the issue to understand where this happen exactly?

magpieuk commented 1 week ago

image

magpieuk commented 1 week ago

There is also another similar issue here: components/solidus_admin/orders/show/summary/component.html.erb

Not sure when this component is displayed yet to verify though.