solidusio / solidus

🛒 Solidus, the open-source eCommerce framework for industry trailblazers.
https://solidus.io
Other
5.04k stars 1.3k forks source link

Feat(Admin): Dynamic routing proxies #5933

Closed mamhoff closed 1 week ago

mamhoff commented 1 week ago

This commit allows the menu of the new admin to accomodate routes from other engines than solidus backend and solidus admin. This is needed for solidus_promotions, which is built as a separate Rails Engine, but it is also convenient for solidus_paypal_commerce_platform or even for integrating gems like AlchemyCMS lateron.

The following are not always needed:

mamhoff commented 1 week ago

This fixes a bug, no?

Not directly, it allows fixes that are present in #5934

github-actions[bot] commented 1 week ago

💚 All backports created successfully

Status Branch Result
v4.4

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.81%. Comparing base (8a060c1) to head (c1e4f12). Report is 6 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #5933 +/- ## ========================================== - Coverage 89.53% 87.81% -1.73% ========================================== Files 782 476 -306 Lines 17982 11656 -6326 ========================================== - Hits 16101 10236 -5865 + Misses 1881 1420 -461 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.