solidusio / solidus

🛒 Solidus, the open-source eCommerce framework for industry trailblazers.
https://solidus.io
Other
5.04k stars 1.3k forks source link

Fix promotions admin UI inconsistency #5936

Open mamhoff opened 1 week ago

mamhoff commented 1 week ago

Summary

This improves the UI of the promotion edit page. The page now has an "activation" menu that allows for configuring either automatic, path-based, single-code or multiple-code activation, similar to how the legacy promotion system does it.

This PR also solves a bug with single-code promotions which previously could not be created without a persisted promotion.

After:

grafik

Before: grafik

The following are mandatory for all PRs:

The following are not always needed:

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.54%. Comparing base (2632096) to head (7c2b843). Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #5936 +/- ## ======================================= Coverage 89.53% 89.54% ======================================= Files 782 782 Lines 17981 17987 +6 ======================================= + Hits 16100 16106 +6 Misses 1881 1881 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.