search

solidusio / solidus_auth_devise

🔑 Devise authentication for your Solidus store.
http://solidus.io
BSD 3-Clause "New" or "Revised" License
52 stars 124 forks source link

Stop raising an exception when callback in UsersController is undefined #110

Closed swcraig closed 6 years ago

swcraig commented 6 years ago

The specs are failing because set_current_order is not defined as a process_action callback. This used to be the case but then it was removed from Solidus.

PR removing this callback: https://github.com/solidusio/solidus/pull/2185

swcraig commented 6 years ago

I noticed a small typo in the commit message. That was my change after Andrew's approval.

stewart commented 6 years ago

In thinking about this a bit more, this solution may be incomplete, as we need to support older versions of Solidus, which will still have set_current_order defined.

swcraig commented 6 years ago

I've made an update adding raise: false. This should be compatible with both versions of Solidus, those that have the callback defined and those that do not.