Shouldn't order history be inside solidus repo?

solidusio / solidus_auth_devise

🔑 Devise authentication for your Solidus store.

http://solidus.io

BSD 3-Clause "New" or "Revised" License

52 stars 124 forks source link

Shouldn't order history be inside solidus repo? #123

Open spaghetticode opened 6 years ago

spaghetticode commented 6 years ago

Hello, I am integrating Solidus ecommerce in an existing app, so I need to use the existing User table. I am not actually using this gem, but I found out that the user orders history (routes, views and so on) are inside this repo. I am a bit confused about it, because authentication does not really concern orders, IMHO these parts of code may better belong inside solidus codebase. What's your opinion on this matter?

tvdeyen commented 6 years ago

Yes, I agree. Would you like to propose a PR to core? This would be very much appreciated.

spaghetticode commented 6 years ago

Alright, I'll work on this soon.

I also noticed that the guest_checkout feature is present in solidus codebase with the preference setting allow_guest_checkout, enabled by default, but to me it seems it's never used there. Again, its functionality is placed in the solidus_auth_devise gem.