prefer ActiveSupport.on_load(:action_controller)

solidusio / solidus_auth_devise

🔑 Devise authentication for your Solidus store.

http://solidus.io

BSD 3-Clause "New" or "Revised" License

52 stars 124 forks source link

prefer ActiveSupport.on_load(:action_controller) #126

Closed patleb closed 5 years ago

patleb commented 5 years ago

trim a little bit the load time

patleb commented 5 years ago

unstable ci: Failure/Error: require "solidus_support/extension/feature_helper"

tvdeyen commented 5 years ago

Not unstable. factory_girl needs to be pinned to 4.8.1

patleb commented 5 years ago

my bad, I've corrected the dependency

patleb commented 5 years ago

I've reverted the commit, the problem wasn't only changing the dependency where I changed it. Also, I don't think this pull request it worth the time I would take make it work. So, from my point of view, if it's working for the test suite with Ruby 2.5+, then it's working as expected.