solidusio / solidus_auth_devise

🔑 Devise authentication for your Solidus store.
http://solidus.io
BSD 3-Clause "New" or "Revised" License
52 stars 124 forks source link

Introduce Rubocop for linting #148

Closed aitbw closed 5 years ago

aitbw commented 5 years ago

In an effort to improve tooling and to achieve a more consistent development environment, this PR aims to include Rubocop to this gem, as well as fix all the offenses based on the Rubocop config file that Solidus uses.

TO-DO:

aitbw commented 5 years ago

~There's one error present in Travis (locally too!) for Solidus v2.5 —apparently, something is interfering with Bundler when it tries to resolve the dependencies.~

Fixed with #149, will rebase once that PR gets merged.

tvdeyen commented 5 years ago

@aitbw builds should work know. Would you mind to rebase as this is great work I would like to merge?

aitbw commented 5 years ago

Done @tvdeyen :ok_hand:

tvdeyen commented 5 years ago

Thanks