Closed aitbw closed 5 years ago
Should we remove the double requirement from rails-controller-testing
in here as well, @kennyadsl?
I must add that doing so would slow down a little bit the dependency resolution, but definitely would not hang the CI build.
Yes, I would remove it here as well. We are adding that just for bundler resolution and I'd love to keep things as simple as possible.
But for both modified gems, or just deface
?
I'd say both, thanks @aitbw !
Done! :heavy_check_mark:
The lack of pessimistic versioning on the following dependencies:
rails-controller-testing
pry-rails
deface
was causing
bundler
to hang indefinitely when resolving dependencies for Solidus v2.5