solidusio / solidus_auth_devise

🔑 Devise authentication for your Solidus store.
http://solidus.io
BSD 3-Clause "New" or "Revised" License
52 stars 124 forks source link

Add missing pessimistic versioning #149

Closed aitbw closed 5 years ago

aitbw commented 5 years ago

The lack of pessimistic versioning on the following dependencies:

was causing bundler to hang indefinitely when resolving dependencies for Solidus v2.5

aitbw commented 5 years ago

Should we remove the double requirement from rails-controller-testing in here as well, @kennyadsl?

I must add that doing so would slow down a little bit the dependency resolution, but definitely would not hang the CI build.

kennyadsl commented 5 years ago

Yes, I would remove it here as well. We are adding that just for bundler resolution and I'd love to keep things as simple as possible.

aitbw commented 5 years ago

But for both modified gems, or just deface?

kennyadsl commented 5 years ago

I'd say both, thanks @aitbw !

aitbw commented 5 years ago

Done! :heavy_check_mark: