search

solidusio / solidus_auth_devise

🔑 Devise authentication for your Solidus store.
http://solidus.io
BSD 3-Clause "New" or "Revised" License
53 stars 128 forks source link

Improve decorators #159

Closed jacobherrington closed 5 years ago

jacobherrington commented 5 years ago

I'm not completely confident that testing would catch all of the problems that could arise from this, but it is passing tests...

Open to feedback on whether or not this change is worth it, I think it is.

jacobherrington commented 5 years ago

Based on the discussion with @spaghetticode and @kennyadsl, I've decided to use this PR just for removing class_eval from the existing decorators.

The decision on a new pattern for organizing "decorators" in Solidus should be discussed and settled in the issue on the main repo.