Logout with DELETE verb by default

solidusio / solidus_auth_devise

🔑 Devise authentication for your Solidus store.

http://solidus.io

BSD 3-Clause "New" or "Revised" License

52 stars 124 forks source link

Logout with DELETE verb by default #161

Closed kennyadsl closed 5 years ago

kennyadsl commented 5 years ago

A while ago Devise changed the default HTTP verb used to sign out from GET to DELETE.

This PR re-aligns this preference default with what is shipped with Devise. It also improves the code to be more dynamic since we were not really supporting changing that preference.

🚨Can be breaking 🚨

Stores that rely on signing out with GET verb will need to change the Devise.sign_out_via configuration at config/initializers/devise.rb:

Devise.sign_out_via = :get

kennyadsl commented 5 years ago

I'm not sure about backward compatibility here and I'm not super sure what to do, leaving WIP for now, please do not merge yet.

kennyadsl commented 5 years ago

We discussed this in the core team meeting and we are fine merging this as is and releasing a new version.