solidusio / solidus_auth_devise

🔑 Devise authentication for your Solidus store.
http://solidus.io
BSD 3-Clause "New" or "Revised" License
52 stars 124 forks source link

Extension maintenance #163

Closed kennyadsl closed 5 years ago

kennyadsl commented 5 years ago

This PR makes two things:

Move rubocop performance cops

This is needed after https://github.com/rubocop-hq/rubocop/issues/5977.

We also need to update the required Ruby version to 2.3 to accommodate the rubocopgem update, required by rubocop-performance.

Add rubocop-rails cops

It provided some useful suggestions which have been fixed within this same PR.