search

solidusio / solidus_auth_devise

🔑 Devise authentication for your Solidus store.
http://solidus.io
BSD 3-Clause "New" or "Revised" License
53 stars 128 forks source link

Fix CI builds #165

Closed aitbw closed 4 years ago

aitbw commented 4 years ago

This PR fixes the failing CI builds by adding selenium-webdriver as a development dependency (for CircleCI), and specifying DB services / enabling chromedriver (for TravisCI)

It also removes poltergeist as it's not being used anymore.

spaghetticode commented 4 years ago

@aitbw as Travis is still in use, I think it would be better to fix that build as well before merging the PR. Would you please add a commit for that? I think that these changes in .travis.yml would do:

services:
  - postgresql
  - mysql

thank you! 🙏

aitbw commented 4 years ago

Done @spaghetticode! Thanks for the heads-up :smile_cat:

kennyadsl commented 4 years ago

I think we can disable Travis at all at this point, WDYT?

spaghetticode commented 4 years ago

@kennyadsl I agree, especially since it's still failing.

aitbw commented 4 years ago

@kennyadsl, I don't have any problems with it. Let me know if you'd like to submit a PR to remove Travis :raised_hands: