search

solidusio / solidus_auth_devise

🔑 Devise authentication for your Solidus store.
http://solidus.io
BSD 3-Clause "New" or "Revised" License
52 stars 124 forks source link

Do not set Spree.user_class after initialize if already set #171

Closed kennyadsl closed 5 years ago

kennyadsl commented 5 years ago

Currently, when this class is set with a custom value using an initializer in the host application, it is not having any effect because this line is always overwriting the custom value with the default one.

Ref: #169

kennyadsl commented 5 years ago

@tvdeyen I think you are right. I supposed (probably wrongly) that the user that reported the issue was using it with an existing "devise" user class. I'll ask for more info in the issue itself.

kennyadsl commented 5 years ago

Closing this one. The issue reported has more to do with solidus_reviews having solidus_auth_devise as a dependency, not allowing people to use it with a custom authentication system.

This is now fixed and this extension still is meant to be used only with Spree::User as Spree.user_class.