search

solidusio / solidus_auth_devise

🔑 Devise authentication for your Solidus store.
http://solidus.io
BSD 3-Clause "New" or "Revised" License
53 stars 128 forks source link

Redirect back if not authorized #192

Closed kennyadsl closed 3 years ago

kennyadsl commented 4 years ago

This is a continuation of https://github.com/solidusio/solidus/pull/3118 and tries to redirect back when there's an authentication error.

~After this is merged I think we can safely merge the one in core as well.~

I updated this PR in order to use the preference introduced by the above core PR. Now the new behavior will be only supported on newer versions of Solidus, if that preference will be explicitly changed.

aldesantis commented 4 years ago

@kennyadsl is this okay to merge?

kennyadsl commented 4 years ago

Not yet, with @jarednorman we found a way to avoid the major bump after this PR, see https://github.com/solidusio/solidus/pull/3118#issuecomment-632766140

kennyadsl commented 3 years ago

@spaghetticode @aldesantis can you review again here, please?

kennyadsl commented 3 years ago

I noticed that the deprecation warning is emitted also on old versions that do not have the preference yet. Going to push a fix for that.