search

solidusio / solidus_auth_devise

🔑 Devise authentication for your Solidus store.
http://solidus.io
BSD 3-Clause "New" or "Revised" License
53 stars 128 forks source link

Allow Solidus 3 version #205

Closed peterberkenbosch closed 3 years ago

peterberkenbosch commented 3 years ago

Since master branch of Solidus is tracking 3.0.0.beta right now we need to make sure that the solidus_version here allows using that Solidus version as well.

aldesantis commented 3 years ago

@peterberkenbosch thanks! I think some specs are failing due to the deprecated address name fields having been removed from Solidus 3. Could you also address those?

jarednorman commented 3 years ago

Why is only 2.10 (but not 2.9) failing?

peterberkenbosch commented 3 years ago

@jarednorman was wondering the same thing. Try to spend some time on this again today.

kennyadsl commented 3 years ago

It may be something related to this check: https://github.com/solidusio/solidus_support/blob/4f3ccabcc2bd1c4d75205fea60cea5c9b256f08f/lib/solidus_support.rb#L25. Maybe ('< 2.10') is not enough for some reason?

kennyadsl commented 3 years ago

Should be fixed with https://github.com/solidusio/solidus_support/pull/59, I'll cut a release when merged.

peterberkenbosch commented 3 years ago

Thanks @kennyadsl

kennyadsl commented 3 years ago

Ready with solidus_support 0.8.1

kennyadsl commented 3 years ago

@peterberkenbosch if you have time for a rebase or just repush, it will trigger the build again, thanks!