search

solidusio / solidus_auth_devise

🔑 Devise authentication for your Solidus store.
http://solidus.io
BSD 3-Clause "New" or "Revised" License
53 stars 128 forks source link

Remove unused login column #212

Open willianveiga opened 3 years ago

willianveiga commented 3 years ago

Remove unused login column.

Fixes #116

willianveiga commented 3 years ago

Maybe it's not related to the same thing, but there was a login column since day one.

Considering this comment, is it possible to consider it related to unfinished and/or delayed plans?

jarednorman commented 3 years ago

If there's not documentation as to what those plans were and the functionality doesn't exist now, I don't think it's worth keeping.

mamhoff commented 1 year ago

I was about to submit this PR just now, and second the removal of this column.

It stores a user's email address in login upon registration, but never updates it when the user updates their email, thus leaving us with garbage data.

@willianveiga would you be up to rebasing it? Otherwise I'll put up another PR with your changes here within a week.