search

solidusio / solidus_auth_devise

🔑 Devise authentication for your Solidus store.
http://solidus.io
BSD 3-Clause "New" or "Revised" License
53 stars 128 forks source link

Solidus 3 support #213

Open vassalloandrea opened 3 years ago

vassalloandrea commented 3 years ago

Support Solidus 3 removing acts_as_paranoid from the user model. Also, the Spree::ParanoiaDeprecations doesn't exist anymore on Solidus 3.0.1.

https://github.com/solidusio/solidus_auth_devise/blob/master/app/models/spree/user.rb

AdnanTheExcellent commented 2 years ago

any updates on this? trying to update to solidus 3 and im encountering this issue

jarednorman commented 2 years ago

I thought #209 fixed this. Did it not?

AdnanTheExcellent commented 2 years ago

it does not. since paranoia was removed as a dependency, you'll get undefined method acts_as_paranoid if paranoia is not in your gemfile.

jarednorman commented 2 years ago

@AdnanTheExcellent Paranoia was removed, but Solidus 3 has Spree::SoftDeletable, so the conditional should be true and acts_as_paranoid should never been called. Is there maybe some issue with loading where the concern isn't yet defined?

AdnanTheExcellent commented 2 years ago

I'm not sure why but it was erroring before when i tried to start my server and worked when i commented out those paranoia lines. i switched back to 2.5.4 and it seems to be working now.