search

solidusio / solidus_auth_devise

🔑 Devise authentication for your Solidus store.
http://solidus.io
BSD 3-Clause "New" or "Revised" License
53 stars 121 forks source link

Devise Encryptor, why authlogic_sha512? #216

Open aaronzdavis opened 3 years ago

aaronzdavis commented 3 years ago

I was surprised to see the default encryptor for Devise was overwritten in this gem. Is there a good reason for this?

When I attempted to export my solidus user database to another platform, Firebase Auth, I couldn't find a solution for importing the passwords using the SHA512 examples found in their docs: https://firebase.google.com/docs/auth/admin/import-users

Perhaps someone here might have a clue how to get passwords over to Firebase Auth.

Here's where the encryptor is being set in this repo. https://github.com/solidusio/solidus_auth_devise/blob/ed42532d91c6c59e74b8f28796af4cc3c5971a34/config/initializers/devise.rb#L43

jarednorman commented 3 years ago

I encountered this recently. We should probably maintain that setting for old apps, but use bcrypt for new installations. I dug into it and the decision to use authlogic_sha512 goes back really far and I couldn't find any explanation in the git history/project for it.