Fix registration errors

solidusio / solidus_auth_devise

🔑 Devise authentication for your Solidus store.

http://solidus.io

BSD 3-Clause "New" or "Revised" License

52 stars 124 forks source link

Closed jhawthorn closed 8 years ago

jhawthorn commented 8 years ago

Due to solidusio/solidus#421 email is no longer in the permitted attributes. This re-adds it

athal7 commented 8 years ago

Email change looks good. Can you say more about the confirmation spec skipping?

jhawthorn commented 8 years ago

@athal7 that spec causes the User class to be reloaded (see https://github.com/solidusio/solidus_auth_devise/blob/master/spec/support/confirm_helpers.rb), which causes a later test to fail.

gmacdougall commented 8 years ago

:+1:

athal7 commented 8 years ago

can we fix it instead of skipping?

:+1:

jhawthorn commented 8 years ago

@athal7 created issue #24. I don't know how we'd fix it, the test really relies on reloading User