solidusio / solidus_auth_devise

🔑 Devise authentication for your Solidus store.
http://solidus.io
BSD 3-Clause "New" or "Revised" License
52 stars 124 forks source link

Update CI configuration #242

Closed waiting-for-dev closed 1 year ago

waiting-for-dev commented 1 year ago

Summary

Run different Solidus versions on different jobs for better error handling.

We're now explicitly providing the ruby version to the executor while using a matrix configuration for better extensibility.

We're now running the linter on Ruby v3.0, as that's the minimal requirement for Solidus master. As a consequence, we disable the cop for following the gemspec version.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

waiting-for-dev commented 1 year ago

CI should be fine once we release a new version of solidus_dev_support with https://github.com/solidusio/solidus_dev_support/pull/205

kennyadsl commented 1 year ago

@waiting-for-dev I think we need to remove this line: https://github.com/solidusio/solidus_auth_devise/blob/97342f783fe2ce131192187c31b0abe1c892b9de/spec/support/spree.rb#L3. It's not needed anymore, now that we have https://github.com/solidusio/solidus_auth_devise/blob/97342f783fe2ce131192187c31b0abe1c892b9de/spec/spec_helper.rb#L24.

waiting-for-dev commented 1 year ago

@waiting-for-dev I think we need to remove this line:

https://github.com/solidusio/solidus_auth_devise/blob/97342f783fe2ce131192187c31b0abe1c892b9de/spec/support/spree.rb#L3

. It's not needed anymore, now that we have https://github.com/solidusio/solidus_auth_devise/blob/97342f783fe2ce131192187c31b0abe1c892b9de/spec/spec_helper.rb#L24

.

Good call. Changed!