search

solidusio / solidus_auth_devise

🔑 Devise authentication for your Solidus store.
http://solidus.io
BSD 3-Clause "New" or "Revised" License
53 stars 128 forks source link

[Rails 7.1] Add empty :new action to Spree::UsersController #250

Closed mamhoff closed 5 months ago

mamhoff commented 5 months ago

Summary

Without this, specs fail with

AbstractController::ActionNotFound:
        The new action could not be found for the :authorize_actions
        callback on Spree::UsersController, but it is listed in the controller's
        :only option.

I guess this is because the views are not in the standard place, thus impeding Rails' ability to dynamically generate empty actions if matching views are present. Anyways: This is good, because it's more explicit.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

kennyadsl commented 5 months ago

@mamhoff do we need to backport this PR?

kennyadsl commented 5 months ago

@mamhoff do we need to backport https://github.com/solidusio/solidus/pull/5420?

Still there's something weird with that failure. If the dummy is generated with ActionCable on those old versions, why the uninitialized constant ApplicationCable::ActionCable error? Ah, maybe because we are manually requiring Rails engines...

kennyadsl commented 5 months ago

By the way, if we need to backport, remember that the backporting labels work on already merged PRs as well.