Call set_current_order explicitly where we need it

solidusio / solidus_auth_devise

🔑 Devise authentication for your Solidus store.

http://solidus.io

BSD 3-Clause "New" or "Revised" License

52 stars 124 forks source link

Call set_current_order explicitly where we need it #51

Closed Murph33 closed 8 years ago

Murph33 commented 8 years ago

set_current_order will be moved out of a before_filter in the ControllerHelpers::Order module in solidus. This is currently hitting the database on just about every frontend page load when we really just need it when someone is signing in. This moves that call to signing in in solidus auth and should be applied in conjunction with https://github.com/solidusio/solidus/pull/1137.

mtomov commented 8 years ago

I think that you'd only need to adjust the comment slightly, as after the Solid PR gets merged, it will be no longer the case that the method will be called before.

stewart commented 8 years ago

This looks great, thank you @Murph33 - would you mind also adding a CHANGELOG.md entry, similar-ish to the one for your corresponding PR in core?