search

solidusio / solidus_auth_devise

🔑 Devise authentication for your Solidus store.
http://solidus.io
BSD 3-Clause "New" or "Revised" License
52 stars 124 forks source link

Add migration version to migrations #82

Closed jordan-brough closed 7 years ago

jordan-brough commented 7 years ago

To eliminate this deprecation warning:

DEPRECATION WARNING: Directly inheriting from ActiveRecord::Migration is deprecated. Please specify the Rails release the migration was written for
stewart commented 7 years ago

As this extension still needs to support older versions of Solidus on Rails 4.2, I don't think we can do this.

stewart commented 7 years ago

I would strongly prefer not to add a new class method to Spree::Auth, for the sole purpose of eliminating these deprecation warnings.

Until Rails begins mandating pinning migration versions, or this extension exclusively supports Rails 5+, I believe the best course of action is to leave the migrations as-is.

Sinetheta commented 7 years ago

In rails 5.1 this is no longer just a warning.

Raise when ActiveRecord::Migration is inherited from directly. CHANGELOG.md