solidusio / solidus_auth_devise

🔑 Devise authentication for your Solidus store.
http://solidus.io
BSD 3-Clause "New" or "Revised" License
52 stars 121 forks source link

Allow Spree::Admin::UserPasswordsController to be accessed from admin… #97

Closed acreilly closed 5 years ago

acreilly commented 7 years ago

… panel.

Since the Spree::Admin::UserPasswordsController was not being used anywhere within solidus the routes were not working. In order to get it working I needed to add a custom route in routes.rb because the default one was being overridden by the frontend route. Since we are calling this endpoint from the admin, we need to skip the action require_no_authentication because we are already authorizing the admin elsewhere. Without it we receive the error "Filter chain halted as :require_no_authentication rendered or redirected"

acreilly commented 7 years ago

This PR depends on #96 . Once that is merged, I rebase and utilize that PRs routes and add a comment next to the skip_before_action : require_no_authentication explaining how it is needed since the admin is logged in while hitting the create endpoint.

tvdeyen commented 7 years ago

@acreilly now that #96 got merged would you mind to rebase with current master?

aitbw commented 5 years ago

Hey @acreilly, thanks a lot for this PR! Would you mind rebasing it against master?

acreilly commented 5 years ago

Closing and opened https://github.com/solidusio/solidus_auth_devise/pull/136